fix: empty "Apps_Error_" toast message when private app installation fails#35189
Merged
kodiakhq[bot] merged 5 commits intodevelopfrom Feb 12, 2025
Merged
fix: empty "Apps_Error_" toast message when private app installation fails#35189kodiakhq[bot] merged 5 commits intodevelopfrom
kodiakhq[bot] merged 5 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 0a38958 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35189 +/- ##
========================================
Coverage 59.31% 59.31%
========================================
Files 2825 2825
Lines 68158 68158
Branches 15123 15123
========================================
Hits 40430 40430
Misses 24900 24900
Partials 2828 2828
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
approved these changes
Feb 12, 2025
tiagoevanp
approved these changes
Feb 12, 2025
pierre-lehnen-rc
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-985
Steps to test or reproduce
Empty error would show up if RC failed to store the app file to disk or if it failed to create an user for the app.
Should be reproduceable by configuring an invalid storage for the apps
Further comments